Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scattergl click event not fired when dragmode is 'select' #1870

Closed
destradafilm opened this issue Jul 11, 2017 · 6 comments
Closed

scattergl click event not fired when dragmode is 'select' #1870

destradafilm opened this issue Jul 11, 2017 · 6 comments
Labels
bug something broken
Milestone

Comments

@destradafilm
Copy link

see this example and change the plot type from 'scatter' to 'scattergl' and you'll see that plotly_click event is not fired when in selection tool

https://codepen.io/plotly/pen/Obxbdv

although it does work on svg 'scatter' plot

@etpinard etpinard added the bug something broken label Jul 11, 2017
@etpinard etpinard added this to the On-par gl2d milestone Jul 11, 2017
@SillyLily0
Copy link

..probably somehow related to this issue: using scatterGL, the default dragmode is set to 'zoom', hence plotly_click events are fired, everything works fine, then I change dragmode to lasso by clicking the lasso icon in the toolbar, dragmode changes to 'lasso', everythings works as expected, plotly_selected is fired instead of 'plotly_click'. However, I would expect to untoggle the lasso mode by again clicking the lasso toolbar icon but it doesn't. In fact, checking the gl2d code it looks like there is no difference between toggling the incon on or off. Would be nice, if untoggling the lasso icon would set the dragmode back to default. Do you agree or am I missing something?

@etpinard
Copy link
Contributor

I would expect to untoggle the lasso mode by again clicking the lasso toolbar icon but it doesn't.

That's true for all a subplot types, gl or not. To return back to the default click on the pan button:

peek 2017-09-18 09-47

@SillyLily0
Copy link

Oh, ok I see. Thanks for pointing that out etpinard.

@etpinard
Copy link
Contributor

etpinard commented Jan 8, 2018

This will be fixed by @dfcreative 's regl-based scattergl work.

@dfcreative would you mind adding a test case in this suite to lock down plotly_click event behavior under dragmode: 'select'?

@dy
Copy link
Contributor

dy commented Jan 16, 2018

091883c adds test of plotly_click in lasso/select modes.

@etpinard
Copy link
Contributor

that's now in #2258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

4 participants