Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone app logs "Installed ..." on exec #77

Closed
etpinard opened this issue Apr 18, 2018 · 5 comments · Fixed by #80
Closed

Standalone app logs "Installed ..." on exec #77

etpinard opened this issue Apr 18, 2018 · 5 comments · Fixed by #80

Comments

@etpinard
Copy link
Contributor

Making an issue out of @n-riesco's #66 (comment):

I've noticed that running the AppImage version now prints out the message:

installed: X-AppImage-BuildId=5a6b0d10-3f0d-11a8-3934-f7a37a902d22 image: X-AppImage-BuildId=5a6b0d10-3f0d-11a8-3934-f7a37a902d22

I don't remember this happening before.

@JamesCropcho
Copy link
Contributor

I would presume it is not bad, that this message is being printed?

Or, is this issue opened with the implied goal to suppress this message?

@etpinard
Copy link
Contributor Author

I think it's pretty bad. Not critical, but pretty bad. That thing isn't useful for anyone.

@JamesCropcho
Copy link
Contributor

I want to bring electron-userland/electron-builder#2807 (comment) to everyone's attention—a conversation I started with the Electron-Builder community regarding @etpinard's concern.

Given a quick glance at the commit referenced, it appears that if we upgrade to v20.9.2 and do nothing else, the unwanted log message will disappear.

So, dare I say, that the problem seems pretty much solved?

James

@etpinard
Copy link
Contributor Author

Awesome! Thanks @JamesCropcho for reaching out to them!

Before calling this fixed, would you mind running npm update electron-builder --save-dev and making a PR with package.json and package-lock.json updates?

@JamesCropcho
Copy link
Contributor

Happily, @etpinard. I have done so: #80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants