Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display an error if propType value is a reference to a variable when building backend components wuth dash-generate-components #1674

Closed
HammadTheOne opened this issue Jun 24, 2021 · 2 comments

Comments

@HammadTheOne
Copy link
Contributor

As pointed out in plotly/dash-bio#564, if we reference a variable within the react.js source code for a component propType, the components are generated for Python and R, but missing the values themselves when mapping from the PropTypes js type object to the Python/R type. For Julia, the components fail to generate with a type-error.

As @alexcjohnson suggested, it makes more sense to have the component generator throw an error when this happens so that component authors can fix this kind of problem up front rather than expecting them to notice a problem later and fix it.

@gvwilson
Copy link
Contributor

@HammadTheOne is this still a concern? thanks - @gvwilson

@gvwilson gvwilson self-assigned this Jul 18, 2024
@gvwilson gvwilson removed their assignment Aug 2, 2024
@HammadTheOne
Copy link
Contributor Author

No, we can close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants