Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlignmentChart Component Improvements #421

Closed
HammadTheOne opened this issue Sep 25, 2019 · 2 comments · Fixed by #583
Closed

AlignmentChart Component Improvements #421

HammadTheOne opened this issue Sep 25, 2019 · 2 comments · Fixed by #583
Labels
nice-to-have Suggestions for improvements.

Comments

@HammadTheOne
Copy link
Contributor

HammadTheOne commented Sep 25, 2019

The AlignmentChart component currently lacks a few features which are relevant to ease of use in creating app layouts and in specifying which data is displayed.

  • One issue is the lack of dynamic auto-resizing to fit a container based on the size of the display. Although the height and width of the chart can be manually set with their respective properties, they remain static and disrupt the layout when viewing the application at different resolutions. An example is shown below with an excess of whitespace. This can be alleviated with CSS workarounds, but the chart remains at the set height and width even if the container around it will resize.

g

  • The tickstart and tickstep optional properties don't seem to be working at all, or at least not as described. Changing the value of these props, even outside the Slider mode which is a known bug, results in no change to the tile annotations or intervals. I'm assuming this is relevant to ORF's based on the description of the property, so would be nice-to-have for certain sequences.

  • A feature which would be helpful to comparing alignments on the chart would be a property or even a dropdown on the chart itself which allows a user to select or deselect which sequences are included in the sequence set aligned on the chart itself. It could include the sequence header as the label and the sequence displayed as the value. Currently this can be done outside the component by modifying the FASTA or CLUSTAL file itself with callbacks, but this may be nice for ease-of-us.

@HammadTheOne HammadTheOne added the nice-to-have Suggestions for improvements. label Sep 25, 2019
@shammamah-zz
Copy link
Contributor

A feature which would be helpful to comparing alignments on the chart would be a property or even a dropdown on the chart itself which allows a user to select or deselect which sequences are included in the sequence set aligned on the chart itself.

IIRC this is a feature of the AlignmentViewer component, which we're removing/deprecating. I'm personally kind of against the idea of adding controls like that to components; @HammadTheOne how would you feel about maybe adding a prop that can take lists of sequence IDs to display? That way, it can be handled within the component but the user also can control it through a Dash app interface.

@HammadTheOne
Copy link
Contributor Author

HammadTheOne commented Oct 3, 2019

I think that would be ideal actually; like you mentioned it would give the user control, and more flexibility on how they want that control displayed.

The only question left is how to handle or collect the sequence ID's. Generally FASTA's include it as the first or second item in the header, but it is something that can vary based on the source. One idea to make it simpler, it could simply be a list of integers based on the position of the sequences in the file, but I'm sure there's a better alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice-to-have Suggestions for improvements.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants