Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better validation when checking version updates #66

Closed
edublancas opened this issue Jun 7, 2023 · 3 comments · Fixed by #68
Closed

better validation when checking version updates #66

edublancas opened this issue Jun 7, 2023 · 3 comments · Fixed by #68

Comments

@edublancas
Copy link
Contributor

we're not performing version validation when checking version updates:

latest = get_latest_version(package_name, version)

this causes the "new version available" message to appear when running development versions

@anupam-tiwari: can you post the screenshot here?

@anupam-tiwari
Copy link
Contributor

Here is the screenshot for reference
Screenshot 2023-06-07 at 4 16 10 PM

@anupam-tiwari
Copy link
Contributor

Can this be the way? The only drawback is we won't be displaying this warning in dev mode, I tried to solve this error using math, the only issue is these versions are in strings and if we try to extract numbers 0.7.8 is not a valid float so the math will fail, let me know your thoughts

if 'dev' in version: 
        return 

@edublancas
Copy link
Contributor Author

yeah, I think your solution makes sense. we don't want to show this message if we're running a development version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants