Black=22.3.0 #1427
Black=22.3.0 #1427
Conversation
|
@tisto thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
✅ Deploy Preview for plone-restapi canceled.
|
|
Be careful because this change can't be backported to the 7.x.x branch, because in version 22.1.0 the python2 formatting support was removed. |
|
Ah right, master is still for 5.2, but not for 2.7. So should be fine here after all. |
| @@ -5,8 +5,9 @@ zc.buildout = | |||
| plone.restapi = | |||
|
|
|||
| # code analysis | |||
| black = 20.8b1 | |||
| black = 22.3.0 | |||
There was a problem hiding this comment.
With version 22.3.0 of black, no need to pin click = 8.0.4. See psf/black#2966
There was a problem hiding this comment.
Wouldn't it be better to pin the black in a constraints.txt? black is not used in buildout.
There was a problem hiding this comment.
Good to know. Thanks! I don't like spreading pins across files and versions.cfg is something that almost all plone packages have, if they follow best practices.
There was a problem hiding this comment.
Though, on second thought we are about to move away from buildout in the long run, so it might be worth to consider. Will look into it...
No description provided.