From ad2773a4dd810b673cdf285af798b7f1e7817da1 Mon Sep 17 00:00:00 2001
From: Daniel Jowett <54800639+djowett-ftw@users.noreply.github.com>
Date: Wed, 29 Apr 2020 19:51:06 +0200
Subject: [PATCH] Backport lost tinymce translations (#930)

* Restore translations of 'Remove link'

* Add missing translationa in tinymce pattern by...

    copying generateModalHtml function from master branch,
    also some backported xml changes from 71ddf6f387

* Add 2 further missing translations in tinymce pattern
---
 mockup/patterns/tinymce/js/links.js        | 4 +++-
 mockup/patterns/tinymce/pattern.js         | 2 ++
 mockup/patterns/tinymce/templates/link.xml | 6 +++---
 news/910.bugfix                            | 5 +++++
 4 files changed, 13 insertions(+), 4 deletions(-)
 create mode 100644 news/910.bugfix

diff --git a/mockup/patterns/tinymce/js/links.js b/mockup/patterns/tinymce/js/links.js
index 5a4d2ec69..68894a106 100644
--- a/mockup/patterns/tinymce/js/links.js
+++ b/mockup/patterns/tinymce/js/links.js
@@ -347,7 +347,7 @@ define([
 
     editor.addButton('unlink', {
       icon: 'unlink',
-      tooltip: 'Remove link(s)',
+      tooltip: 'Remove link',
       cmd: 'unlink',
       stateSelector: 'a[href]'
     });
@@ -472,6 +472,8 @@ define([
         internal: this.options.text.internal,
         external: this.options.text.external,
         anchor: this.options.text.anchor,
+        anchorLabel: this.options.text.anchorLabel,
+        target: this.options.text.target,
         linkTypes: this.options.linkTypes,
         externalText: this.options.text.external,
         emailText: this.options.text.email,
diff --git a/mockup/patterns/tinymce/pattern.js b/mockup/patterns/tinymce/pattern.js
index a49dfff02..e8c27060c 100644
--- a/mockup/patterns/tinymce/pattern.js
+++ b/mockup/patterns/tinymce/pattern.js
@@ -140,6 +140,8 @@ define([
         externalText: _t('External URL (can be relative within this site or absolute if it starts with http:// or https://)'),
         email: _t('Email Address'),
         anchor: _t('Anchor'),
+        anchorLabel: _t('Select an anchor'),
+        target: _t('Target'),
         subject: _t('Email Subject (optional)'),
         image: _t('Image'),
         imageAlign: _t('Align'),
diff --git a/mockup/patterns/tinymce/templates/link.xml b/mockup/patterns/tinymce/templates/link.xml
index e2deff878..53ad0177f 100644
--- a/mockup/patterns/tinymce/templates/link.xml
+++ b/mockup/patterns/tinymce/templates/link.xml
@@ -39,7 +39,7 @@
 
       <% if(_.contains(linkTypes, 'email')){ %>
       <fieldset class="linkType email" data-linkType="email">
-        <legend id="tinylink-email">Email</legend>
+        <legend id="tinylink-email"><%- emailText %></legend>
         <div class="form-inline">
           <div class="form-group main">
             <label><%- emailText %></label>
@@ -58,7 +58,7 @@
         <legend id="tinylink-anchor"><%- anchor %></legend>
         <div>
           <div class="form-group main">
-            <label>Select an anchor</label>
+            <label><%- anchorLabel %></label>
             <div class="input-wrapper">
               <select name="anchor" class="pat-select2" data-pat-select2="width:500px" />
             </div>
@@ -71,7 +71,7 @@
 
     <div class="common-controls">
       <div class="form-group">
-        <label>Target</label>
+        <label><%- target %></label>
         <select name="target">
           <% _.each(targetList, function(target){ %>
             <option value="<%- target.value %>"><%- target.text %></option>
diff --git a/news/910.bugfix b/news/910.bugfix
new file mode 100644
index 000000000..f33a9b215
--- /dev/null
+++ b/news/910.bugfix
@@ -0,0 +1,5 @@
+tinymce pattern: Add missing translations by...
+    - copying generateModalHtml function from master branch,
+    - adding some backported xml changes from 71ddf6f387
+    - adding 2 further translations (not yet in master)
+[djowett-ftw]