-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fingerprint every file in SPA #320
Comments
In my initial testing I was running into After doing several cache clears ctrl-f5 and using incognito/private browsing windows, it appears to work as expected and I can't recreate the error. If folks do run into this however, please let me know! |
I attempted to load the fingerprint only when replacing the import path (1005ca6). This resulted in a different fingerprint for each import. This was not my intention, but I didn't think this would be a problem, but it kept throwing the |
I can't seem to avoid the |
I found a good way to replicate the issue with the hashed folder in case folks want to test:
|
We recently updated our cache busting strategy to use query params: #315
My hope was that breaking the entrypoint would have a cascade effort to breaking other cached files referenced downstream. I thought this was working based on initial tests, but that does not seem to be the case now that I've used it more extensively.
It puts us in a hard place, breaking the cache using a folder runs the risk of inactive Chrome tabs not correctly fetching the assets when reactivating, and only breaking the entrypoint runs the risk of serving up stale content already cached. I think we're going to have to ultimately fingerprint (with query string) every file in the SPA. We should be able to do this using gopack, since we're already rewriting every import to resolve to a valid ESM path during the build.
The text was updated successfully, but these errors were encountered: