Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement subplebbit.roles proofs #33

Open
estebanabaroa opened this issue Dec 25, 2023 · 3 comments
Open

implement subplebbit.roles proofs #33

estebanabaroa opened this issue Dec 25, 2023 · 3 comments

Comments

@estebanabaroa
Copy link
Member

estebanabaroa commented Dec 25, 2023

the UIs need some proof that a mod is really a mod, otherwise you could just add anyone as a mod to make you sub appear legitimate

the solution to this is to add a field to

SubplebbitRole {
  role: string
  lastCommentEdit: CommentEditPublication
}

then every time a mod takes an action, we can add it to lastCommentEdit, so the UI can confirm that a moderator was active at least once (not fake added) and how long ago he was active.

plebbit-js should validate the lastCommentEdit signatures, and the sub ipns should be invalid if it contains an invalid signature. .eth of authors should only be fetched if resolvedAuthorAddresses is not false

NOTE: eventually we could store commentEdits as a linked list, with commentEdit.previousCid or something, would be good for auditing, people could fetch all the edits by all mods

@estebanabaroa
Copy link
Member Author

estebanabaroa commented Feb 28, 2024

we also need a commentCid to be able to link to the mod from the UI sidebar, so it should be

SubplebbitRole {
  role: string
  lastCommentEdit?: CommentEditPublication
  lastCommentCid?: string // the last reply or post of the mod inside the sub (if any)
}

reminder that linking authors require cid, like /u/name.eth/c/<cid>

@Rinse12
Copy link
Member

Rinse12 commented Aug 30, 2024

NOTE: eventually we could store commentEdits as a linked list, with commentEdit.previousCid or something

Should we add previousCid to CommentEditPublication as well? It'd require adding comment edits to IPFS, which is not something we're doing at the moment

@estebanabaroa
Copy link
Member Author

Should we add previousCid to CommentEditPublication as well? It'd require adding comment edits to IPFS, which is not something we're doing at the moment

not at the moment, it was just something to think about. since we're having DHT issues at the moment, we should actually try to think of ways to reduce the amount of cids subs have to reprovide, so we probably wont want to add more CIDs to the design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants