Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning when using varargs in Scala 2.13.0 #238

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Fix deprecation warning when using varargs in Scala 2.13.0 #238

merged 2 commits into from
Jul 12, 2019

Conversation

flamingelk
Copy link

Fix deprecation warning in Scala 2.13.0 when using varargs.

Matt Jones and others added 2 commits July 11, 2019 11:13
@lightbend-cla-validator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

1 similar comment
@lightbend-cla-validator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@octonato
Copy link
Contributor

Fixes #237

Copy link
Contributor

@octonato octonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flamingelk.

LGTM, but I'm holding up the merge becasue it seems that there is an issue with the CLA. It passed the check, but at the same time it added a message saying that one of your commits can't be identified.

I need to check how to proceed with that. Alternatively, if you squash your branch and do a forced push using a user that GitHub can identify, then I think we are good.

@mergify mergify bot merged commit 7e33860 into playframework:1.4.x Jul 12, 2019
@octonato
Copy link
Contributor

@flamingelk, I checked and we are fine. Don't need to squash yourself. We will do the merge.

@mkurz
Copy link
Member

mkurz commented Jul 13, 2019

Reminder to also port this to the master branch.

@marcospereira marcospereira changed the title Fixes issue 237 Fix deprecation warning when using varargs in Scala 2.13.0 Jul 14, 2019
@mkurz
Copy link
Member

mkurz commented Jul 15, 2019

@marcospereira Looks like mergify doesn't care about the needs-forwardport label in the twirl repo.

@octonato
Copy link
Contributor

Added PR for forward port, removing label

@pme123
Copy link

pme123 commented Sep 24, 2019

I use Play 2.7.3 - and with that Twirl 1.4.2.

I have still deprecation warnings. see https://stackoverflow.com/questions/58058690/scala-2-13-passing-an-explicit-array-value-to-a-scala-varargs-method-is-depreca

Do I have to change something in my code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants