-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warning when using varargs in Scala 2.13.0 #238
Conversation
Fix varargs compilation for Scala 2.13.0
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
1 similar comment
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
Fixes #237 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @flamingelk.
LGTM, but I'm holding up the merge becasue it seems that there is an issue with the CLA. It passed the check, but at the same time it added a message saying that one of your commits can't be identified.
I need to check how to proceed with that. Alternatively, if you squash your branch and do a forced push using a user that GitHub can identify, then I think we are good.
@flamingelk, I checked and we are fine. Don't need to squash yourself. We will do the merge. |
Reminder to also port this to the master branch. |
@marcospereira Looks like mergify doesn't care about the |
Added PR for forward port, removing label |
I use Play 2.7.3 - and with that Twirl 1.4.2. I have still deprecation warnings. see https://stackoverflow.com/questions/58058690/scala-2-13-passing-an-explicit-array-value-to-a-scala-varargs-method-is-depreca Do I have to change something in my code? |
Fix deprecation warning in Scala 2.13.0 when using varargs.