-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect calculation the column of error for template with first line comments #571
Comments
Can you give more detail or an example? |
Sorry, Matthias @mkurz . I didn't have time to finish it yesterday. Just I needed an issue number for cross-link in another PR with adding copyrights.
Example right now is had in our tests, that were broken when I added copyrights header to twirl templates 😞 twirl/compiler/src/test/scala/play/twirl/compiler/test/CompilerSpec.scala Lines 174 to 189 in 7b6c41d
It is related with that Twirl use first comment block as comments for constructor args and has a special behavior for this comments. Yesterday I hadn't found a quick and nice solution for this bud and decided move this to separate issue because I don't think that it's a stopper to merge #568 🤷♂️ |
No description provided.
The text was updated successfully, but these errors were encountered: