From 0e6e7d235e5f727f2f990fc725c0018122fb128c Mon Sep 17 00:00:00 2001 From: Chua Chee Seng Date: Thu, 22 Sep 2022 22:08:20 +0800 Subject: [PATCH] Added check-binary-compatibility to CI. --- .github/workflows/ci.yml | 5 +++++ build.sbt | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f9b56ea4..9b1e003f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,6 +9,10 @@ jobs: with: cmd: sbt validateCode + check-binary-compatibility: + name: Binary Compatibility + uses: playframework/.github/.github/workflows/binary-check.yml@v2 + check-docs: name: Docs uses: playframework/.github/.github/workflows/cmd.yml@v2 @@ -19,6 +23,7 @@ jobs: runs-on: macos-latest needs: - "check-code-style" + - "check-binary-compatibility" - "check-docs" steps: - name: Checkout diff --git a/build.sbt b/build.sbt index 036e138e..ce09c4ff 100644 --- a/build.sbt +++ b/build.sbt @@ -55,6 +55,11 @@ lazy val mimaSettings = Seq( ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.scalatestplus.play.PlaySpec.*"), ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.scalatestplus.play.PlaySpec.*"), ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalatestplus.play.MixedPlaySpec.*"), + // Dropping deprecated phantom-js support. + ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSFactory"), + ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSFactory$"), + ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSInfo"), + ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSInfo$") ), mimaPreviousArtifacts := previousVersion.map(organization.value %% name.value % _).toSet )