make default jdk 11 #1387
Merged
make default jdk 11 #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolntsev
approved these changes
Feb 17, 2022
|
It looks like after a481dd3 there is no option to use java 8. Because eclipse.jdt.core was updated to 3.28.0 and starting from 3.27.0 it requires java 11. |
xael-fry
reviewed
Feb 21, 2022
|
|
||
| Values: @1.7@ (No longer supported since 1.5.0), @1.8@, @9@, @10@, @11@, @12@, @13@, @14@, @15@, @17@. | ||
| Values: @1.7@ (No longer supported since 1.5.0), @1.8@ (No longer supported since 1.6.x), @9@ (No longer supported since 1.6.x), @10@ (No longer supported since 1.6.x), @11@, @12@, @13@, @14@, @15@, @17@. |
There was a problem hiding this comment.
I think that it should be 'No longer supported since 1.7.0' has the 1.6.0 still support java 8 ?
There was a problem hiding this comment.
Only if it will be next release. Because code already is uncompilable with java 8.
xael-fry
approved these changes
Feb 22, 2022
|
Merged thanks @aleksandy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 6dabc53 play! is compiled and tested on jdk 11 and 17 in CI. So in my opinion it's good cause to migrate to jdk 11 in the next release.