Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warning in CachingAsyncHttpClient #752

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Apr 8, 2023

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you checked that both Scala and Java APIs are updated?
  • Have you updated the documentation for both Scala and Java sections?
  • Have you added tests for any changed functionality?

Fixes

fix warning

Purpose

Background Context

https://github.com/AsyncHttpClient/async-http-client/blob/7a370af58dc8895a27a14d0a81af2a3b91930651/client/src/main/java/org/asynchttpclient/RequestBuilder.java#L43-L46

[warn] /home/runner/work/play-ws/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/cache/CachingAsyncHttpClient.scala:223:19: constructor RequestBuilder in class RequestBuilder is deprecated
[warn]     val rb      = new RequestBuilder(request)
[warn]                   ^

References

@mkurz mkurz merged commit 2584c27 into playframework:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants