[2.1.x] ssl-config 0.6.0 (like akka 2.6.19) #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkurz
commented
Jan 12, 2022
| } | ||
| } | ||
| logger.warn( | ||
| "validateDefaultTrustManager is not doing anything since play-ws 2.1.8, it was useful only in Java 7 and below"); |
There was a problem hiding this comment.
|
Also see discussion in akka/akka#30871 and akka/akka#31046 |
mkurz
changed the title
mkurz
force-pushed
the
ssl-config-0.6.0
branch
from
96cbbde to
708bb48
Compare
|
Let's use the current akka snapshot for now, cut a play-ws 2.1.8-RC1 release to unblock Play's 2.8.x branch |
|
Because this was cherry-picked from the master branch and akka did the same upgrade to ssl-config 0.6.0 I will merge myself now so I can cut the RC |
This was referenced Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to upgrade ssl-config in play-ws 2.1.x to 0.6.0, because akka did the same a couple of days ago, and because Play's cron build for the 2.8.x branch uses the latest akka snapshot, the build is now broken: https://app.travis-ci.com/github/playframework/playframework/jobs/554697000#L1703
We need to wait for akka 2.6.19 however.