ssl-config-core 0.6.0 (was 0.4.3) + cachecontrol 2.1.0

[scala-steward]

Updates com.typesafe:ssl-config-core from 0.4.3 to 0.5.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (0.4.3).
You might want to review and update them manually.

project/plugins.sbt

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.typesafe", artifactId = "ssl-config-core" } ]

labels: library-update, semver-minor, old-version-remains

[mkurz]

0.6.0 out already: https://github.com/lightbend/ssl-config/releases/tag/v0.6.0

[mkurz]

Reopening, I will just push the update to that branch and also include latest cachecontrol

[mkurz]

@wsargent The changes you made in ssl-config (lightbend/ssl-config#302) makes the build fail:

[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:251:26: value allowWeakProtocols is not a member of com.typesafe.sslconfig.ssl.SSLLooseConfig
[error]     if (!sslConfig.loose.allowWeakProtocols) {
[error]                          ^
[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:269:9: not found: value Ciphers
[error]         Ciphers.recommendedCiphers.filter(existingCiphers.contains(_)).toArray
[error]         ^
[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:272:26: value allowWeakCiphers is not a member of com.typesafe.sslconfig.ssl.SSLLooseConfig
[error]     if (!sslConfig.loose.allowWeakCiphers) {
[error]                          ^
[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:273:31: not found: value Ciphers
[error]       val deprecatedCiphers = Ciphers.deprecatedCiphers
[error]                               ^
[warn] bootstrap class path not set in conjunction with -source 8
[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:349:33: value disabledKeyAlgorithms is not a member of com.typesafe.sslconfig.ssl.SSLConfigSettings
[error]     val constraints = sslConfig.disabledKeyAlgorithms
[error]                                 ^
[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:350:17: not found: value AlgorithmConstraintsParser
[error]       .map(a => AlgorithmConstraintsParser.parseAll(AlgorithmConstraintsParser.expression, a).get)
[error]                 ^
[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:350:53: not found: value AlgorithmConstraintsParser
[error]       .map(a => AlgorithmConstraintsParser.parseAll(AlgorithmConstraintsParser.expression, a).get)
[error]                                                     ^
[error] /home/travis/build/playframework/play-ws/play-ahc-ws-standalone/src/main/scala/play/api/libs/ws/ahc/AhcConfig.scala:352:32: not found: type AlgorithmChecker
[error]     val algorithmChecker = new AlgorithmChecker(loggerFactory, Set(), constraints)
[error]                                ^
[info] Done compiling.
[error] 8 errors found
[error] (play-ahc-ws-standalone / Compile / compileIncremental) Compilation failed

Can you help out?

[mkurz]

Ping @wsargent, could you please have a look? Thanks a lot!

[wsargent]

Looking. I'll make a branch for this if I can't add commits directly.

[wsargent]

Got the main bits working, but we'll need to release Akka HTTP as well based on the ssl-config-core:

[error] ! 
[error]  org.specs2.specification.core.FatalExecution: 'boolean com.typesafe.sslconfig.ssl.SSLLooseConfig.allowWeakProtocols()' (AkkaSSLConfig.scala:186)
[error] com.typesafe.sslconfig.akka.AkkaSSLConfig.configureProtocols(AkkaSSLConfig.scala:186)
[error] com.typesafe.sslconfig.akka.AkkaSSLConfig.<init>(AkkaSSLConfig.scala:99)
[error] com.typesafe.sslconfig.akka.AkkaSSLConfig$.createExtension(AkkaSSLConfig.scala:32)
[error] com.typesafe.sslconfig.akka.AkkaSSLConfig$.createExtension(AkkaSSLConfig.scala:21)
[error] akka.actor.ActorSystemImpl.registerExtension(ActorSystem.scala:1158)
[error] akka.actor.ExtensionId.apply(Extension.scala:78)
[error] akka.actor.ExtensionId.apply$(Extension.scala:77)
[error] com.typesafe.sslconfig.akka.AkkaSSLConfig$.apply(AkkaSSLConfig.scala:27)
[error] com.typesafe.sslconfig.akka.AkkaSSLConfig$.apply(AkkaSSLConfig.scala:21)
[error] akka.http.scaladsl.HttpExt.<init>(Http.scala:82)

[wsargent]

I'll need to go through the docs and sanity check the test suite but it should compile and pass tests now.

[wsargent]

I had to upgrade to Akka HTTP 10.2.x to remove the dependency on ssl-config-akka.

[mkurz]

@wsargent Thanks! I pushed commits to satisfy MiMa, plus akka-http already has a 10.2.6 release. (BTW: That means we have to finally upgrade do akka-http 10.2.x in Play as well: playframework/playframework#10411)

@wsargent Can we merge that PR now or is there something missing?

[wsargent]

I should check the play ws docs so they don't reference anything that is not valid.

[wsargent]

Checked the play docs in the README.md file and removed an unused import, I think that's it @mkurz

[mkurz]

Thanks @wsargent. Let's merge!

[mkurz]

@Mergifyio backport 2.1.x

We need to upgrade ssl-config in play-ws 2.1.x to 0.6.0, because akka did the same a couple of days ago, and because Play's cron build for the 2.8.x branch uses the latest akka snapshot, the build is now broken: https://app.travis-ci.com/github/playframework/playframework/jobs/554697000#L1703

Exception in thread "specs2-2" java.lang.NoSuchMethodError: com.typesafe.sslconfig.ssl.SSLLooseConfig.allowWeakProtocols()Z

[mergify]

backport 2.1.x

❌ No backport have been created

• Backport to branch 2.1.x failed
  Pull request with merge commit are not supported

[mkurz]

Manual backport of the ssl-config upgrade: #638