Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try Scala 3.3.1-RC4 #756

Merged
merged 2 commits into from
Jul 16, 2023
Merged

Try Scala 3.3.1-RC4 #756

merged 2 commits into from
Jul 16, 2023

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Jul 15, 2023

No description provided.

@mkurz mkurz force-pushed the scala_3.3.1-RC4 branch from a3dafa7 to fea25c3 Compare July 15, 2023 19:32
@mkurz
Copy link
Member Author

mkurz commented Jul 15, 2023

@xuwei-k Upgrading to Scala 3.3.1-RC4 causes following error: https://github.com/playframework/play-slick/actions/runs/5563861714/jobs/10163111701?pr=756

Any idea?

@mkurz mkurz force-pushed the scala_3.3.1-RC4 branch from fea25c3 to c2e7177 Compare July 15, 2023 23:05
@xuwei-k
Copy link
Contributor

xuwei-k commented Jul 16, 2023

🤔

-  def hooks(lifecycle: DefaultApplicationLifecycle): Array[_] = {
+  def hooks(lifecycle: DefaultApplicationLifecycle): Seq[_] = {
     val hooksField = lifecycle.getClass.getDeclaredField("hooks")
     hooksField.setAccessible(true)
-    hooksField.get(lifecycle).asInstanceOf[ConcurrentLinkedDeque[_]].toArray()
+    hooksField.get(lifecycle).asInstanceOf[ConcurrentLinkedDeque[_]].toArray().toSeq
   }

@mkurz
Copy link
Member Author

mkurz commented Jul 16, 2023

👍 Let's do that

@mkurz mkurz merged commit 2024fa6 into playframework:main Jul 16, 2023
@mkurz mkurz deleted the scala_3.3.1-RC4 branch July 16, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants