Add test for constructing Writes with case class #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levinson
force-pushed
the
constructing-writes-scala3-compile-bug
branch
4 times, most recently
from
1f5807a to
da3e62e
Compare
Updated syntax in README to support Scala 3
levinson
force-pushed
the
constructing-writes-scala3-compile-bug
branch
from
da3e62e to
4aee6a7
Compare
cchantep
requested changes
May 20, 2024
|
|
||
| val serialized = Json.stringify(Json.toJson(location)) | ||
| serialized.mustEqual("""{"lat":1.1,"long":2.2}""") | ||
| Json.fromJson[Location](Json.parse(serialized)).mustEqual(JsSuccess(location)) |
| @@ -246,19 +246,28 @@ import play.api.libs.functional.syntax._ | |||
| implicit val locationWrites: Writes[Location] = ( | |||
| (JsPath \ "lat").write[Double] and | |||
| (JsPath \ "long").write[Double] | |||
| )(unlift(Location.unapply)) | |||
| )(location => { | |||
There was a problem hiding this comment.
Snippets should show use cases for both versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Background
The syntax in the README for constructing Writes fails to compile in Scala 3:
This is due to the following change to case class unapply: https://docs.scala-lang.org/scala3/guides/migration/incompat-other-changes.html#explicit-call-to-unapply
Following the guidance from the migration guide pattern binding is used instead of call to unapply.
This PR fixes #1039 by updating the syntax in README to support Scala 3 and add new unit test.