Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support compressed.ply spherical harmonics #7127

Closed
wants to merge 6 commits into from

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Nov 20, 2024

This PR:

  • adds support for loading and rendering compressed spherical harmonic data in compressed.ply files
  • the details of the format will be described elsewhere with the release in SuperSplat, but in summary:
    • 3 palettes of spherical harmonics coefficients are stored per file (one for each sh band)
    • each splat stores 9 indices into this data (r,g,b indices for band 1, 2, 3), totalling 128bits
  • this results in compressed files being roughly twice the size with 3 bands of spherical harmonics
  • small type fix for specifying texture data

Notes:

  • we are adding support here for 0 or 3 bands of spherical harmonics, but may add explicit support for 1 and 2 bands in future
  • the palette data is stored in halfs for the space savings, but it might be preferable to use floats

@slimbuck slimbuck added area: graphics Graphics related issue enhancement labels Nov 20, 2024
@slimbuck slimbuck requested a review from a team November 20, 2024 16:40
@slimbuck slimbuck self-assigned this Nov 20, 2024
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What an achievement. Is it possible to put some examples numbers in the PR....along with info about expected quality loss.

@slimbuck
Copy link
Member Author

After more thorough testing it seems the palette approach results in much more complication with arguable advantage. Closing this PR in favour of a simpler approach that results in larger files, but does not suffer from color degradation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants