Enable loading of texture assets in unit tests #6928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklundin
added a commit
that referenced
this pull request
Sep 10, 2024
This reverts commit a9d5cc6.
marklundin
added a commit
that referenced
this pull request
Sep 11, 2024
marklundin
pushed a commit
that referenced
this pull request
Sep 11, 2024
marklundin
added a commit
that referenced
this pull request
Sep 17, 2024
* Enable loading of texture assets in unit tests (#6928) * Update package.json and import statements * Refactor asset loading test in AssetRegistry --------- Co-authored-by: Will Eastcott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments the Node-based unit tests to be able to load Image objects. This means that we can now unit test engine code that loads texture assets from images. This is critical to be able to test much of the engine (including sprites, elements, particle systems and much more).
I confirm I have read the contributing guidelines and signed the Contributor License Agreement.