Implement traffic drop notifications #4300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
force-pushed
the
drop-notifications
branch
from
4a843f6 to
a08f3e2
Compare
|
aerosol
force-pushed
the
drop-notifications
branch
from
0534a31 to
2353076
Compare
ukutaht
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Changes look good to me.
Since we're in a sort of housekeeping mode I would propose some further clean-ups for things that were touched in this PR:
- Make the
settings/email-reportspage a Liveview - Remove
Doubledependency from traffic_change_notifier_tests.exs file
RobertJoonas
pushed a commit
that referenced
this pull request
Jul 12, 2024
* Expose current visitors 12h aggregate * Remove unused site association * Distinct drop/spike notification factories * Rename modules accordingly + implement drop handling * Rename periodic oban service * Implement drop email * Rest of the owl * Update changelog * Update moduledoc * Update moduledoc * Min threshold to 1 * Threshold 1 * Remove merge artifact * Put panel behind a feature flag * Format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR implements traffic drop notifications, similar to already implemented spike notifications.
Postgres migration included that extends thespike_notificationstable with atypefield indicating whether the notification is tracking drops or spikes. Table name should be probably left intact - since we don't have a way to run a migration renaming it.It's important we don't send out drop notifications if e.g. traffic is barred via payment issues, hence the worker looks owner's
accept_traffic_untilup.BTW the PR makes it no longer possible to set a negative threshold.
Tests
Changelog
Documentation
Dark mode