Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTP Crash after upgrading to 2.1.2 #4619

Closed
2 tasks done
adamu opened this issue Sep 25, 2024 · 4 comments · Fixed by #4631
Closed
2 tasks done

TOTP Crash after upgrading to 2.1.2 #4619

adamu opened this issue Sep 25, 2024 · 4 comments · Fixed by #4631
Assignees

Comments

@adamu
Copy link

adamu commented Sep 25, 2024

Past Issues Searched

  • I have searched open and closed issues to make sure that the bug has not yet been reported

Issue is a Bug Report

  • This is a bug report and not a feature request, nor asking for self-hosted support

Using official Plausible Cloud hosting or self-hosting?

Self-hosting

Describe the bug

After upgrading to 2.1.2 I see the following error in the console on app startup, and TOTP codes fail to verify:

12:24:56.655 [error] GenServer Plausible.Site.Cache.All terminating
** (ArgumentError) errors were found at the given arguments:

  * 1st argument: the table identifier does not refer to an existing ETS table

    (stdlib 6.0) :ets.lookup(Plausible.Auth.TOTP.Vault.Config, :config)
    (cloak 1.1.2) lib/cloak/vault.ex:285: Cloak.Vault.read_config/1
    (plausible 0.0.1) deps/cloak/lib/cloak/vault.ex:252: Plausible.Auth.TOTP.Vault.decrypt/1
    (plausible 0.0.1) deps/cloak_ecto/lib/cloak_ecto/type.ex:64: Plausible.Auth.TOTP.EncryptedBinary.load/1
    (ecto 3.12.2) lib/ecto/type.ex:1031: Ecto.Type.process_loaders/3
    (ecto 3.12.2) lib/ecto/repo/queryable.ex:423: Ecto.Repo.Queryable.struct_load!/6
    (ecto 3.12.2) lib/ecto/repo/queryable.ex:269: Ecto.Repo.Queryable.preprocess/4
    (ecto 3.12.2) lib/ecto/repo/queryable.ex:270: Ecto.Repo.Queryable.preprocess/4
Last message: :"$cycle

Expected behavior

No error and TOTP works without crashing.

Screenshots

No response

Environment

No response

@adamu adamu changed the title TOTP Crash after upgrading to 1.12.2 TOTP Crash after upgrading to 2.1.2 Sep 25, 2024
@adamu
Copy link
Author

adamu commented Sep 25, 2024

It looks like this might be a one-off upgrade issue. Restarting again + clearing cookies resolved the issue.

@mentalstring
Copy link

mentalstring commented Sep 25, 2024

Perhaps not the best place to report this as it's not even TOTP related, but its perhaps not worth an issue of its own and it relates to the previous comment.

After upgrading today to 2.1.2 I also couldn't login (login form would simply show up again; no error message). But, after reading the comment above and clearing cookies, everything worked as expected. Leaving it here in case it saves someone some time.

@ruslandoga
Copy link
Contributor

@mentalstring 👋

#4621 would probably fix the cookie issue.

@ruslandoga
Copy link
Contributor

ruslandoga commented Sep 25, 2024

👋 @adamu

This seems like a race-condition in app startup. I'll look into it tomorrow. Thank you for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants