Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom header example to more relevant example #4364

Open
gilzow opened this issue Jan 31, 2025 · 0 comments · May be fixed by #4366
Open

Update custom header example to more relevant example #4364

gilzow opened this issue Jan 31, 2025 · 0 comments · May be fixed by #4366
Assignees

Comments

@gilzow
Copy link
Collaborator

gilzow commented Jan 31, 2025

Where on docs.platform.sh should be changed?

https://docs.platform.sh/create-apps/web/custom-headers.html
https://docs.upsun.com/create-apps/web/custom-headers.html

What exactly should be updated?

Current example uses .mp3 as the example file type but mp3 is already a known mime type in the nginx.conf

[email protected]:~$ cat /etc/nginx/mime.types | grep mp3
    audio/mpeg                                       mp3;

Instead, let's use a file type that isn't known that might need to use the customer header to set the correct content-type (e.g. *.md)

Additional context

I think we should also add links to this page from https://docs.upsun.com/create-apps/app-reference/single-runtime-image.html#locations and https://docs.upsun.com/create-apps/app-reference/composable-image.html#locations (and platform.sh equivalents) in the Description field for headers

@gilzow gilzow self-assigned this Jan 31, 2025
@gilzow gilzow linked a pull request Jan 31, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant