Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodeadm init hangs and tries to get stable version from internet #55

Merged
merged 1 commit into from
Aug 11, 2018

Conversation

puneetguptanitj
Copy link
Contributor

We hit kubernetes/kubernetes#54188 if Kind and APIVersion is not set in config.yaml. (These are set as omit if empty upstream)

if Kind and APIVersion is not set in config.yaml. (These are set
as omit if empty upstream)
Copy link
Contributor

@dlipovetsky dlipovetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be set in any case, so 👍

Copy link
Contributor

@sarun87 sarun87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch.

@puneetguptanitj puneetguptanitj merged commit 76edce5 into master Aug 11, 2018
@dlipovetsky dlipovetsky deleted the private/add-api-and-kind-in-masterconfig branch August 12, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants