Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Proper Ellipsis rule breaks transcluded links #611

Closed
mnaoumov opened this issue Feb 2, 2023 · 4 comments · Fixed by #613
Closed

Bug: Proper Ellipsis rule breaks transcluded links #611

mnaoumov opened this issue Feb 2, 2023 · 4 comments · Fixed by #613
Assignees
@mnaoumov
Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature resolution/update-made A change has been made that should resolve this issue or request

Comments

@mnaoumov
Copy link
Contributor

mnaoumov commented Feb 2, 2023

Describe the Bug

Proper Ellipsis rule breaks transcluded links

How to Reproduce

![title](a...b.md)

![](c...d.png)

Apply Proper Ellipsis rule

Expected Behavior

The note is unchanged

Actual behavior Behavior

The three consecutive dots ... were replaced with a single Unicode character …, breaking the links

![title](a…b.md)

![](c…d.png)
@mnaoumov mnaoumov added the bug Something isn't working label Feb 2, 2023
@pjkaufman
Copy link
Collaborator

Sounds like I need to add an exception for links though it seems like bad practice to include multiple dots in a row in a file name. @mnaoumov , did you have a fix for this or do you want me to create one real quickly before I mage the next release?

@pjkaufman pjkaufman added the markdown General Markdown or Markdown related issue or feature label Feb 2, 2023
@pjkaufman
Copy link
Collaborator

This only looks to affect images or things in the image markdown format.

@mnaoumov
Copy link
Contributor Author

mnaoumov commented Feb 2, 2023

@pjkaufman yes, I almost finished my fix

@pjkaufman
Copy link
Collaborator

Gotcha. I will wait on it then. It should just be adding the ignore type of image to the list of ignore types.

@mnaoumov mnaoumov mentioned this issue Feb 2, 2023
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Releasing in Obsidian Linter Feb 2, 2023
@pjkaufman pjkaufman added the resolution/update-made A change has been made that should resolve this issue or request label Feb 2, 2023
@pjkaufman pjkaufman moved this from Releasing to Done in Obsidian Linter Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnaoumov mnaoumov

Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature resolution/update-made A change has been made that should resolve this issue or request
Projects
Obsidian Linter
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip images together with links mnaoumov/obsidian-linter
2 participants
@mnaoumov @pjkaufman