Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Intent URL Normalization #370

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Jacek-Gawel
Copy link

In cases where the URL sent in the intent contained spaces, the application did not open the given URL but instead used it as a search query in Google.

By normalizing the URL, the text from the intent is now correctly opened as a URL.

This issue is known to occur with Firebase App Distribution, which sends the app name in the intent. If the app name contains spaces, the link is not opened but is treated as a search query.

Replace Intent ExtraText spaces with %20

 - replace spaces with %20
@plateaukao
Copy link
Owner

Thank you for providing the PR. I'll check whether it will make other scenarios malfunctioning; if not, I'll merge it.

@plateaukao
Copy link
Owner

Hi, @Jacek-Gawel
could you provide me several example of Firebase App Distribution usage?
I would like to verify the scenarios.
Also, could you fix indent issues in the PR?
Otherwise I may just send a commit directly based on your PR, in order not to send another PR to fix those indentations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants