Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarks font size far too small on entering URL #447

Closed
dredmorbius opened this issue Dec 7, 2024 · 3 comments
Closed

Bookmarks font size far too small on entering URL #447

dredmorbius opened this issue Dec 7, 2024 · 3 comments
Assignees

Comments

@dredmorbius
Copy link

dredmorbius commented Dec 7, 2024

Please write necessary information as described below. If information is not enough, I may not have time to look into it.

What device and app version are you using

  • Device: Onyx BOOX Max Lumi
  • OS: Android 10
  • EinkBro Version: 14.0.0

Describe the bug

The font used to display matching bookmarks when editing URLs (if enabled) is far too small.

To Reproduce

Steps to reproduce the behavior.

Example description:

  1. Ensure that "Show Bookmarks when editing URL" is enabled in settings (Behaviour tab).
  2. Tap on URL widget on toolbar.
  3. Matching bookmarks will be displayed in two columns in the webpage area. Font is infinitesimally small. Us olds can't read that stuff.

Note too that under Onyx's app configuration I have DPI set to 250 for EinkBro. If I scale that up, app controls are too large.

Related issue is that the font size for URL entry is also smallish, but not nearly so bad as the bookmarks.

What's the behavior on following similar browsers

n/a

Do not report that it works in CHROME, FIREFOX, or EDGE, BRAVE. That does not help. Since these are full-fledge browsers

Expected behavior

Font size should be roughly the default system font size for Android. Maybe a point or two smaller, but no less.

Change seems to have occurred sometime between v 11.mumble, which I'd had pinned for a while. I noticed the small fonts after unpinning and upgrading EinkBro recently.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Again: my DPI settings may be affecting this, and font size for URL entry is also painfully small, though not quite as bad as bookmarks.

I'd prefer EinkBro simply follow Android system font sizes for this and other App text (e.g., settings, toolbar descriptions, etc.), rather than, say, adding Yet Another Configuration for app font size.

If a screenshot would help I can try generating some. I may be able to install an older version of the app and contrast the older and current (14.0.0) appearance.

@plateaukao
Copy link
Owner

I enlarged the font and verified it on BOOX Max3. Should be better now.

@dredmorbius
Copy link
Author

Thanks! Target release?

@plateaukao
Copy link
Owner

already merged codes. should be next version.

plateaukao added a commit that referenced this issue Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants