feat(circleci): add typescript check #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmq
force-pushed
the
typescript-reviewdog
branch
from
e903b52 to
e665e2a
Compare
difernandez
approved these changes
Jul 26, 2022
| name: Run tsc | ||
| shell: /bin/bash | ||
| command: | | ||
| cat tmp/files_to_lint | grep -E '.+\.(ts)$' | xargs yarn run tsc --noEmit ./app/javascript/types/*.d.ts \ |
There was a problem hiding this comment.
de dónde sale que se pueda corres yarn run tsc? de tener typescript, o vue-tsc en el package?
There was a problem hiding this comment.
Se agrega con typescript, que se instala antes en la receta.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds type checking to reviewdog.