Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(): add delayed job recipe #41

Merged
merged 1 commit into from
Feb 26, 2016
Merged

feat(): add delayed job recipe #41

merged 1 commit into from
Feb 26, 2016

Conversation

ldlsegovia
Copy link
Collaborator

No description provided.

@@ -0,0 +1,17 @@
if selected?(:delayed_job)
gather_gem "daemons"
gather_gem "delayed_job_active_record"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

porque hay que agregar la gema "daemons"??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creo que como ahora usamos heroku, y el comando se agrega en el Procfile, ya no hay necesidad de esto.
Heroku se encargara de mantener corriendo ese proceso.

Ademas como bien pusiste en el Procfile ya no usariamos el comando bin/delayed_jobs mencionado ahi, sino que el task que provee activejob...

mmmm, pensandolo bien.... usamos activejob para delayed_jobs en platanus??? cual crees que la practica comun?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ActiveJob es relativamente nuevo y no he tenido mucha oportunidad de verlo en un proyecto nuevo. Sin embargo, es mucho más simple y escalable usarlo que no (en tanto, si la bd se vuelve un cuello de botella gracias a DJ, uno puede migrar casi con nada a resque, sidekiq u otros). Por eso creo que deberíamos usarlo de ese modo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,
entonces habria que sacar daemons, ya que vamos a usar activejob, vamos ha echar a andar el proceso con las tareas que provee activejobs, ademas de que heroku se encarga de el proceso.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De acuerdo con lo que dice @juliogarciag , saco daemons entonces.

@ldlsegovia
Copy link
Collaborator Author

@blackjid ya saqué daemons

@blackjid
Copy link
Member

fantastic!

blackjid added a commit that referenced this pull request Feb 26, 2016
feat(): add delayed job recipe
@blackjid blackjid merged commit 324a8ae into master Feb 26, 2016
@blackjid blackjid deleted the delayed-job branch February 26, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants