Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/mjml #405

Merged
merged 4 commits into from
Jun 13, 2022
Merged

Feat/mjml #405

merged 4 commits into from
Jun 13, 2022

Conversation

flouMicaza
Copy link
Contributor

@flouMicaza flouMicaza commented Jun 2, 2022

Context

This PR adds MJML that is a markup language designed to reduce the pain of coding a responsive email.
To show future developers how to use MJML the recipe adds a mailer example and a default layout shown in the picture al the end of this PR.

Changes

Mailer recipe

  • To use images in the mailer example, the config.action_mailer.asset_host was defined for the production and development environments.
  • Some tests where added to cover the case when no mailer is provided.

Mjml

  • The new recipe install the mjml-rails gem and the yarn package only if there is a mailer setted.
  • It copies the files for the example mailer.

imagen

@flouMicaza flouMicaza requested a review from gmq June 2, 2022 16:35
@gmq
Copy link
Contributor

gmq commented Jun 10, 2022

@flouMicaza flouMicaza force-pushed the feat/mjml branch 2 times, most recently from 6f6f1c7 to 5f2bc9c Compare June 13, 2022 14:54
@flouMicaza
Copy link
Contributor Author

flouMicaza commented Jun 13, 2022

Se me fue agregarlo pero podría ir en la platanus-config ™️ https://github.com/platanus/potassium/blob/e4f98c45f1d5f18a3c3aa8be86ab6c83d72e41cd/lib/potassium/platanus_config.rb

Mmm qué hace ese archivo, por lo que entendí son los defaults de Platanus, pero mjml se instalará por default siempre que haya mailer.

@flouMicaza flouMicaza requested a review from gmq June 13, 2022 15:41
@flouMicaza flouMicaza merged commit 4b2213c into master Jun 13, 2022
@flouMicaza flouMicaza deleted the feat/mjml branch June 13, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants