feat/tailwind 2 compat build #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaacosta
force-pushed
the
feat/upgrade-to-tailwind-to-compat-build
branch
7 times, most recently
from
b6e75e9 to
b725173
Compare
iaacosta
force-pushed
the
feat/upgrade-to-tailwind-to-compat-build
branch
from
b725173 to
8480f2c
Compare
gmq
reviewed
Jun 1, 2021
iaacosta
force-pushed
the
feat/upgrade-to-tailwind-to-compat-build
branch
from
8480f2c to
3abadab
Compare
gmq
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
TailwindCSS 2 is compatible with PostCSS 8, but Webpack 4 enforces PostCSS 7, which breaks the generated project if the user does not explicitly specify a lower version of Tailwind (e.g.
1.9.2) or fixes this issue.Changes
Uses the special Tailwind 2
tailwindcss@npm:@tailwindcss/postcss7-compatpackage version that is compatible withpostcss@^7in generated projects. This change should not be needed anymore when@rails/webpacker@^6is released and upgraded in Potassium.Both
postcss@^7andautoprefixer@^9aren't strictly needed as dependencies because they are also dependencies of@rails/[email protected]and are installed anyways. Nevertheless, I'd rather explicitly specify the dependencies of this compatibility build.Changes might conflict with the ones done in #350 relative to TailwindCSS version.
Closes #349