Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rack-cors): update rack cors to ~> 1.1 #269

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

rjherrera
Copy link
Member

This PR updates rack-cors in order to remove vulnerability warnings from freshly bundled potassium projects. After this PR we should address #202.

closes #265

@rjherrera rjherrera requested a review from ldlsegovia February 16, 2020 15:39
Copy link
Collaborator

@ldlsegovia ldlsegovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Te parece que tengamos mejor algo como:

    config.middleware.insert_before 0, Rack::Cors do
      allow do
        origins '*'
        resource '/public/*', headers: :any, methods: :get

        resource '/api/*',
          headers: :any,
          methods: [:get, :post]
      end
    end

@rjherrera
Copy link
Member Author

I suggested something very similar but I'll address that in other PR! Thank you

@rjherrera rjherrera merged commit 5a63ff5 into master Feb 17, 2020
@rjherrera rjherrera deleted the update-rack-cors branch February 17, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

rack-cors is outdated and dependabot warns vulnerability immediately after project creation
2 participants