Update bundler to 2.0 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjherrera
force-pushed
the
update-bundler
branch
2 times, most recently
from
428cb52 to
6a17b79
Compare
blackjid
reviewed
Jan 28, 2020
| @@ -18,16 +18,16 @@ Gem::Specification.new do |spec| | |||
| spec.test_files = spec.files.grep(%r{^(test|spec|features)/}) | |||
| spec.require_paths = ["lib"] | |||
|
|
|||
| spec.add_development_dependency "bundler", "~> 1.7" | |||
| spec.add_development_dependency "bundler", "~> 2.0" | |||
There was a problem hiding this comment.
for some unknown mystical reason CI wont work with bundler >2.0.2 so I think that for consistency gemspec and ci build should both use roughly the same version
rjherrera
force-pushed
the
update-bundler
branch
from
6a17b79 to
6d7a655
Compare
rjherrera
force-pushed
the
update-bundler
branch
from
6d7a655 to
fe3ad75
Compare
blackjid
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates bundler to
~> 2.0. It also sorts alphabetically gemspec dependencies for consistency.Some unknown bugs in the CI build were happening related to cache issues. For now cache restore will be disabled until I figure out the best way to deal with it.
closes #249