Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary data (docker containers, directories, databases) should be erased after each test #210

Closed
rjherrera opened this issue Jul 12, 2019 · 0 comments · Fixed by #216
Closed
Assignees

Comments

@rjherrera
Copy link
Member

After running tests for potassium itself, containers are not dropped, so they fill the host's computer with dummy/useless containers. The after block in database_container_spec.rb should be available as a helper or default behavior for every other spec.

In the same line, databases and directories should be removed as a default behavior after every spec. They are usually deleted in a before(:all) block in every recipe's spec, but that's because they are not deleted in the previous spec. That should be done in an after block in every spec, or in a default helper.

@rjherrera rjherrera changed the title Docker containers should be erased after each test Temporary data (docker containers, directories, databases) should be erased after each test Jul 12, 2019
@difernandez difernandez self-assigned this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants