Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack-dev-server doesn't work on default install #166

Closed
llekn opened this issue Aug 6, 2018 · 4 comments
Closed

webpack-dev-server doesn't work on default install #166

llekn opened this issue Aug 6, 2018 · 4 comments
Assignees
Labels

Comments

@llekn
Copy link
Contributor

llekn commented Aug 6, 2018

After a clean install running ./bin/webpack/dev-server fails because a version mismatch (rails/webpacker#1303)

Steps to reproduce the problem:

  • Create a new project: potassium create foo
  • Go to project folder: cd foo
  • Try to run webpack-dev-server: ./bin/webpack-dev-server
@rjherrera rjherrera self-assigned this Apr 12, 2019
@rjherrera
Copy link
Member

Using the latest potassium build from master (rake install from the repo folder), I tried to reproduce this issue choosing Vue and I couldn't, everything seems to work fine after a clean installation, and I'm able to run ./bin/webpack-dev-server.

There seems to be an issue after a clean installation choosing Angular 2, but it doesn't appear to be related to the one mentioned in that issue.

Could you try again and see if it still happens? If not we should close this and open another one for the specific issue with angular 2 (or maybe deprecate it 😬)

@llekn
Copy link
Contributor Author

llekn commented Apr 12, 2019

Hi young @rjherrera

I just re-tried this and can confirm it works OK with Angular. Too bad that it still needs some manual config as the resultant package.json ends with an incompatible version of core-js that needs to be downgraded, but it is a rails-webpacker (happens with a rails new myapp --webpack=angular too) thing so I don't think it is productive to continue with this.

I'll close this Issue as it seems resolved.

@llekn llekn closed this as completed Apr 12, 2019
@llekn
Copy link
Contributor Author

llekn commented Apr 12, 2019

Ah, one last thing. Potassium keeps mentioning Angular 2 (from the time that everybody thought that version 2 would be years among us) but it will install last stable version of Angular.io (currently 7.2.x). Maybe is time to change the name of the option?

@rjherrera
Copy link
Member

I like the idea, but maybe we should remove the number, as it will always be the last one. Maybe we should open a new issue with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants