From bd11c580c9d29ae3f18ddaa0e3ea0c41db173b66 Mon Sep 17 00:00:00 2001 From: Raimundo Herrera Date: Fri, 31 Jan 2020 14:22:54 -0300 Subject: [PATCH 1/3] feat(cli): change default to none for tests --- lib/potassium/cli_options.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/potassium/cli_options.rb b/lib/potassium/cli_options.rb index 95d99b44..7e2505a7 100644 --- a/lib/potassium/cli_options.rb +++ b/lib/potassium/cli_options.rb @@ -16,7 +16,7 @@ module Potassium::CliOptions # rubocop:disable Metrics/ModuleLength type: :flag, name: [:email_service, :email], desc: "Decides which email adapter to use. Available: aws_ses, sendgrid, none", - default_test_value: "aws_ses" + default_test_value: "None" }, { type: :switch, @@ -71,7 +71,7 @@ module Potassium::CliOptions # rubocop:disable Metrics/ModuleLength name: "storage", desc: "Decides which file storage to use. Available: active_storage, paperclip, none", default_value: "none", - default_test_value: "active_storage" + default_test_value: "None" }, { type: :switch, @@ -85,7 +85,7 @@ module Potassium::CliOptions # rubocop:disable Metrics/ModuleLength type: :flag, name: "background_processor", desc: "Decides which background processor to use. Available: sidekiq, delayed_job, none", - default_test_value: "sidekiq" + default_test_value: "None" }, { type: :switch, From bf7f2fa3f5028f1421acb8c29928c73acefcd271 Mon Sep 17 00:00:00 2001 From: Raimundo Herrera Date: Fri, 31 Jan 2020 15:02:49 -0300 Subject: [PATCH 2/3] feat(create): skip default rails steps being done in specific recipes --- CHANGELOG.md | 3 ++- lib/potassium/cli/commands/create.rb | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ee3e4dda..fd1f2c7c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,9 +6,10 @@ Features: - Update ActiveAdmin to 2.6 [#246](https://github.com/platanus/potassium/pull/246) - Update bundler to 2.0 [#250](https://github.com/platanus/potassium/pull/250) - Update Rails to 6.0.2 [#251](https://github.com/platanus/potassium/pull/251) + - Improve specs performance [#259](https://github.com/platanus/potassium/pull/259) Fix: - - Correctly use cache for bundle dependencies in CircleCi build [#244](https://github.com/platanus/potassium/pull/244) + - Correctly use cache for bundle dependencies in CircleCI build [#244](https://github.com/platanus/potassium/pull/244) and [#258](https://github.com/platanus/potassium/pull/258) ## 5.2.3 diff --git a/lib/potassium/cli/commands/create.rb b/lib/potassium/cli/commands/create.rb index f491566c..79e2d664 100644 --- a/lib/potassium/cli/commands/create.rb +++ b/lib/potassium/cli/commands/create.rb @@ -25,6 +25,7 @@ module Potassium::CLI template = template_finder.default_template template.cli_options = options template.source_paths << Rails::Generators::AppGenerator.source_root + ARGV.push('--skip-webpack-install', '--skip-bundle') template.start end From 9b4d2a529e8b1b4f8dc57a422fa9e227fd77b284 Mon Sep 17 00:00:00 2001 From: Raimundo Herrera Date: Fri, 31 Jan 2020 15:18:29 -0300 Subject: [PATCH 3/3] feat(frontend): remove webpacker gem gathering as it is done by rails --- lib/potassium/recipes/front_end.rb | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/potassium/recipes/front_end.rb b/lib/potassium/recipes/front_end.rb index 6193d02b..29f0f1bf 100644 --- a/lib/potassium/recipes/front_end.rb +++ b/lib/potassium/recipes/front_end.rb @@ -17,8 +17,6 @@ def ask def create return if [:none, :None].include? get(:front_end).to_sym - gather_gem 'webpacker' - recipe = self after(:gem_install) do value = get(:front_end)