Remove Separate API Service for Web Interface #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bLopata
approved these changes
Nov 21, 2024
Comment on lines
+40
to
+45
| // useEffect(async () => { | ||
| // const newConv = await createConversation(); | ||
| // setConversationId(newConv?.conversationId); | ||
| // mutateConversations([newConv!]); | ||
| // }, [conversations]); | ||
|
|
There was a problem hiding this comment.
Suggested change
| // useEffect(async () => { | |
| // const newConv = await createConversation(); | |
| // setConversationId(newConv?.conversationId); | |
| // mutateConversations([newConv!]); | |
| // }, [conversations]); | |
Comment on lines
+366
to
+389
| responseReader.releaseLock(); | ||
| responseReader = null; | ||
|
|
||
| mutateMessages(); | ||
| } catch (error) { | ||
| console.error('Chat error:', error); | ||
| setCanSend(true); | ||
| } finally { | ||
| // Cleanup | ||
| if (thoughtReader) { | ||
| try { | ||
| thoughtReader.releaseLock(); | ||
| } catch (e) { | ||
| console.error('Error releasing thought reader:', e); | ||
| } | ||
| } | ||
| if (responseReader) { | ||
| try { | ||
| responseReader.releaseLock(); | ||
| } catch (e) { | ||
| console.error('Error releasing response reader:', e); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: release the responseReader lock in the finally clause.
| throw new Error(`No response body for ${type} stream`); | ||
| } | ||
|
|
||
| console.log(`${type} stream connected successfully`); |
There was a problem hiding this comment.
Suggested change
| console.log(`${type} stream connected successfully`); |
| @@ -73,17 +83,18 @@ export default function Sidebar({ | |||
| }); | |||
|
|
|||
| if (isConfirmed) { | |||
| await conversation.delete(); | |||
| await deleteConversation(conversation.conversationId); | |||
| // await conversation.delete(); | |||
There was a problem hiding this comment.
Suggested change
| // await conversation.delete(); |
| @@ -20,11 +21,14 @@ | |||
| "@stripe/stripe-js": "^4.9.0", | |||
| "@supabase/ssr": "^0.5.2", | |||
| "@supabase/supabase-js": "^2.45.6", | |||
| "ai": "^4.0.1", | |||
There was a problem hiding this comment.
Are we using this? I didn't see any references to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.