Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn BlockChain<T>.GetStates() into GetState() #510

Closed
dahlia opened this issue Sep 10, 2019 · 2 comments
Closed

Turn BlockChain<T>.GetStates() into GetState() #510

dahlia opened this issue Sep 10, 2019 · 2 comments
Labels
hacktoberfest Newcomer-welcoming issues for Hacktoberfest help wanted Extra attention is needed suggestion Suggestion or feature request

Comments

@dahlia
Copy link
Contributor

dahlia commented Sep 10, 2019

As it seems rare to look up multiple states at a time, and dealing with multiple addresses makes the implementation of BlockChain<T>.GetStates() complicated, I suggest to turn GetStates() into GetState() which takes only one Address at a call instead of IEnumerable<Address>.
@dahlia dahlia added suggestion Suggestion or feature request help wanted Extra attention is needed labels Sep 10, 2019
@dahlia dahlia added the hacktoberfest Newcomer-welcoming issues for Hacktoberfest label Sep 26, 2019
@qtuu
Copy link
Contributor

qtuu commented Oct 2, 2019

I would like to give this a try.

@qtuu qtuu mentioned this issue Oct 2, 2019
Merged
@moreal
Copy link
Contributor

moreal commented Oct 18, 2019

This is resolved by #563.

@moreal moreal closed this as completed Oct 18, 2019
@dahlia dahlia mentioned this issue Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Newcomer-welcoming issues for Hacktoberfest help wanted Extra attention is needed suggestion Suggestion or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dahlia @qtuu @moreal