Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better bank holiday handling #22

Open
linusnorton opened this issue Feb 15, 2020 · 2 comments
Open

Better bank holiday handling #22

linusnorton opened this issue Feb 15, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@linusnorton
Copy link
Contributor

Perhaps make use of https://www.npmjs.com/package/date-holidays
@linusnorton linusnorton added the enhancement New feature or request label Feb 15, 2020
@chadselph
Copy link
Contributor

On this topic, I think there's actually a mistake in the current holidays; it has both the Scotland and NotScotland holidays as the last monday in August but apparently in Scotland it should be the first monday in august.

@tafflin
Copy link

tafflin commented Feb 7, 2022

@chadselph Looks like you are talking about changing the file Container.ts, line with
"AugustBankHolidayScotland"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chadselph @linusnorton @tafflin