Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use native EventTarget instead of a custom implementation #191

Open
kevinhikaruevans opened this issue Apr 25, 2023 · 0 comments
Open

Use native EventTarget instead of a custom implementation #191

kevinhikaruevans opened this issue Apr 25, 2023 · 0 comments

Comments

@kevinhikaruevans
Copy link

kevinhikaruevans commented Apr 25, 2023 •
edited
Loading

Is there a reason that this library is using its own implementation of EventTarget, here: https://github.com/pladaria/reconnecting-websocket/blob/master/reconnecting-websocket.ts#L268? Why not just extend from EventTarget?

It would be nice to not be confined to the events in events.ts, so I could dispatch other events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinhikaruevans