Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WrapCGI might not work with non-buffering PSGI server #544

Open
miyagawa opened this issue Jan 2, 2016 · 1 comment
Open

WrapCGI might not work with non-buffering PSGI server #544

miyagawa opened this issue Jan 2, 2016 · 1 comment

Comments

@miyagawa
Copy link
Member

miyagawa commented Jan 2, 2016

I was reading the code of WrapCGI and the current code that does read from psgi.input uses the diamond operator to read the whole input from filehandles, which will probably not work with PSGI servers where input buffering is off (uwsgi for instance).

https://github.com/plack/Plack/blob/master/lib/Plack/App/WrapCGI.pm#L12-L17

@ccodewa
Copy link

ccodewa commented Jan 30, 2016

apache 2.4 mod_perl 2.09
Plack::Handler::Apache2
Plack::App::WrapCGI with execute => 1

[Fri Jan 29 23:37:38.694671 2016] [mpm_prefork:notice] [pid 6397] AH00163: Apache/2.4.16 (FreeBSD) OpenSSL/1.0.1p-freebsd mod_perl/2.0.9 Perl/v5.20.2 configured -- resuming normal operations
[Fri Jan 29 23:37:38.694714 2016] [core:notice] [pid 6397] AH00094: Command line: '/usr/local/sbin/httpd -D NOHTTPACCEPT'
[Fri Jan 29 23:37:47.155331 2016] [perl:error] [pid 6400] [client 127.0.0.1:16738] Not a GLOB reference at /usr/local/lib/perl5/site_perl/Plack/App/WrapCGI.pm line 15.\n
[Fri Jan 29 23:37:48.122626 2016] [perl:error] [pid 6401] [client 127.0.0.1:48978] Not a GLOB reference at /usr/local/lib/perl5/site_perl/Plack/App/WrapCGI.pm line 15.\n

  • Apache works without execute => 1
  • Plackup works with execute => 1
  • Apache 2.2 mod_perl 2.05 on ubuntu 12.02 server works with execute => 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants