-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more tests for the new submission wizard #8346
Comments
- Tests comments for the editor - Tests submission language different from UI locale
- Tests comments for the editor - Tests submission language different from UI locale
The following PRs add several of the high-value tests listed above, but not all of them. PRs: |
- Tests comments for the editor - Tests submission language different from UI locale
- Tests comments for the editor - Tests submission language different from UI locale
@NateWr, looking at the screenshot from https://app.travis-ci.com/github/pkp/ojs/jobs/600315309, it looks like the French language option isn't being found at all in the user navigation menu. The error |
- Tests comments for the editor - Tests submission language different from UI locale
#8346 Add tests for the submission wizard
pkp/pkp-lib#8346 Add tests for the submission wizard
Thanks @asmecher, that helped! I was able to find a test that disables the UI language. I went ahead and re-enabled it in that test to "reset" the data: https://github.com/pkp/pkp-lib/pull/8876/files#diff-33549da02ff3ea0d4410934cdb3f9f063321bf8849a132890471bb4902bab43fR31-R36 Oddly, our test data at pkp/datasets doesn't seem to include this setting. I thought the test data was saved after all the tests finished. But is the test data maybe saved before some of the integration tests are finished? |
👍👍 The datasets are saved after the data build tests, but before the integration tests. |
In that case, it might be good to encourage integration tests to "reset" any conditions that have been modified as part of the tests. If side effects can be isolated then it's easier to debug a single test without having to run the full suite. |
Describe the issue
Due to time constraints, there are several features of the new submission wizard that are not tested as part of the integration tests. The following are tests that would be good to add before 3.4's final release.
High-value Tests
Other tests
Additional Comments
I'm assigning this to 3.4 in the hope that we can get some of these tests implemented before the final release. But I suspect we'll bump most of them.
The text was updated successfully, but these errors were encountered: