Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Translations (Spanish) #4029

Closed
stranack opened this issue Aug 31, 2018 · 7 comments
Closed

Missing Translations (Spanish) #4029

stranack opened this issue Aug 31, 2018 · 7 comments
Assignees

Comments

@stranack
Copy link

##user.register.form.privacyConsent##
##user.register.form.emailConsent##
##user.reviewerPrompt.optin##

@carzamora
Copy link
Contributor

carzamora commented Sep 2, 2018

Hi @marcbria,
can you provide some translation? To help you I pasted below the chain of text in English, and indicated the file in which you can find those:

pkp-lib/locale/en_US/user.xml
<message key="user.register.form.privacyConsent"><![CDATA[Yes, I agree to have my data collected and stored according to the <a href="{$privacyUrl}" target="_blank">privacy statement</a>.]]></message>

pkp-lib/locale/en_US/user.xml
<message key="user.register.form.emailConsent">Yes, I would like to be notified of new publications and announcements.</message>

ojs/locale/es_ES/locale.xml
<message key="user.reviewerPrompt.optin">Yes, I would like to be contacted with requests to review submissions to this journal.</message>

@marcbria
Copy link
Collaborator

marcbria commented Sep 7, 2018

Hi,

Thanks Kevin to rise it up and Carlos for the search.

I took a look and the 3 chains are included in the last delivery we made before vacations, and @mtub merged them all against master branch. Please, Marco, correct me if I'm talking rubbish.

Any way, thanks for the advice. We like to keep es_ES translation as complete as we can.

Cheers,
m.

@Moradnejad
Copy link

Moradnejad commented Jul 3, 2019

I can't find user.reviewerPrompt.optin anywhere. Are you sure it is included in English?

@carzamora @marcbria

@carzamora
Copy link
Contributor

Hi @Moradnejad,

is here in the English file: https://github.com/pkp/ojs/blob/4a71d1835e842d0e405f2683c773425331874981/locale/en_US/locale.xml#L205

@Moradnejad
Copy link

Thanks @carzamora

@marcbria
Copy link
Collaborator

If I remember well, all this was fixed.
@asmecher , do you mind to close the issue?

@asmecher
Copy link
Member

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants