Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all albums with Artist.albums() #884

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

jjlawren
Copy link
Collaborator

@jjlawren jjlawren commented Feb 6, 2022

Description

Some time ago, the /library/metadata/<artist_rating_key>/children endpoint started returning only "true" albums and moved special albums (e.g., EPs, live albums, compilations, etc) to the artist's hubs.

This updates the Artist.albums() method to return all albums associated with an artist.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@alextasmota
Copy link

Thank you jjlawren.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants