Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup download methods #847

Merged
merged 5 commits into from
Nov 20, 2021
Merged

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Oct 24, 2021

Description

  • Cleanup all download methods for audio, photos, and videos.
  • Sanitizes the download filename.
  • Also adds the subfolder option to download shows into season folders, artists into album folders, and photos into photo album folders.

Fixes #293
Closes #448
Closes #579

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit 01131c9 into pkkid:master Nov 20, 2021
@JonnyWong16 JonnyWong16 deleted the feature/download branch November 21, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant