Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server transcodeImage method #845

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

JonnyWong16
Copy link
Collaborator

Description

Adds new parameters blur, background, imageFormat, minSize, and upscaleto the PlexServer.transcodeImage() method.

Potential breaking change from renaming the first argument from media to imageUrl to be more clear. Also the default arguments minSize=True and upscale=True.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 force-pushed the feature/transcodeImage branch from b06ee99 to 850dbe4 Compare October 17, 2021 00:36
@JonnyWong16 JonnyWong16 force-pushed the feature/transcodeImage branch from 850dbe4 to 57309aa Compare October 17, 2021 00:38
@JonnyWong16 JonnyWong16 merged commit 34a4218 into pkkid:master Nov 20, 2021
@JonnyWong16 JonnyWong16 deleted the feature/transcodeImage branch November 21, 2021 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant