Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting of resource connections #653

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

JonnyWong16
Copy link
Collaborator

Description

The MyPlexResouce connections were not sorted in the correct order for connection attempts. This corrects the connections to the following order:

  • Local
    • HTTPS, HTTP
  • Remote
    • HTTPS, HTTP
  • Relay
    • HTTPS, HTTP

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

Copy link
Collaborator

@jjlawren jjlawren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is a solid improvement!

@jjlawren jjlawren merged commit a263f49 into pkkid:master Feb 2, 2021
@JonnyWong16 JonnyWong16 deleted the bugfix/resource_connection branch May 13, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants