Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playable._prettyfilename() should sanitise filename #293

Closed
andrey-yantsen opened this issue Sep 5, 2018 · 3 comments · Fixed by #847
Closed

Playable._prettyfilename() should sanitise filename #293

andrey-yantsen opened this issue Sep 5, 2018 · 3 comments · Fixed by #847
Labels

Comments

@andrey-yantsen
Copy link
Contributor

andrey-yantsen commented Sep 5, 2018

It's expected that the method _prettyfilename() would return a valid filename, because of filename in its name and docstring :) But if you have an Artist named Lovely/Bones, with an Album named very*very and a track named dev/\0 — you would be unpleasantly surprised when you try to save it under suggested name.

@Hellowlol
Copy link
Collaborator

I dont use the music feature. Feel Free to change it so It’s sanitized.

@andrey-yantsen
Copy link
Contributor Author

andrey-yantsen commented Sep 6, 2018 via email

@Hellowlol
Copy link
Collaborator

The only reason I added it was that I wanted a way to get downloads in showname.sxex format. Ill fix this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants