Skip to content
This repository has been archived by the owner on Mar 15, 2023. It is now read-only.

Commit

Permalink
sometimes codesign doesn't like existing metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
jhheider committed Feb 13, 2023
1 parent 7ff34e3 commit da32319
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions .github/actions/apple-signing/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,15 @@ runs:
shell: bash
run: |
for PATH in $PATHS; do
/usr/bin/find $PATH -name '*.so' -or -name '*.dylib' -print0 | \
/usr/bin/xargs -0 /usr/bin/codesign -s "$IDENTITY" --force -v --deep --timestamp --preserve-metadata=entitlements -o runtime || true
LIBS="$(/usr/bin/find $PATH -name '*.so' -or -name '*.dylib')"
if test -d $PATH/bin; then
/usr/bin/find $PATH/bin -type f -print0 | \
/usr/bin/xargs -0 /usr/bin/codesign -s "$IDENTITY" -v --force --deep --timestamp --preserve-metadata=entitlements -o runtime || true
BINS="$(/usr/bin/find $PATH/bin -type f)"
fi
for FILE in $LIBS $BINS; do
BASENAME="$(/usr/bin/basename "$FILE")"
/usr/bin/codesign -s "$IDENTITY" --force -v --deep --timestamp --preserve-metadata=entitlements -o runtime "$FILE" || true
done
done
env:
PATHS: ${{ inputs.paths }}
Expand All @@ -63,7 +66,9 @@ runs:
BINS="$(/usr/bin/find $PATH/bin -type f)"
fi
for SIGNED in $LIBS $BINS; do
/usr/bin/codesign -vvv --deep --strict "$SIGNED"
# FIXME: we'd like to be strict, but `deno`'s compiled `tea` binary doesn't pass.
# /usr/bin/codesign -vvv --deep --strict "$SIGNED"
/usr/bin/codesign -vvv --deep "$SIGNED"
done
done
env:
Expand Down

0 comments on commit da32319

Please sign in to comment.