Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PJSUA-LIB account option to add user defined parameters to the Contact header #930

Closed
pjsipbot opened this issue Aug 4, 2009 · 0 comments

Comments

@pjsipbot
Copy link
Collaborator

pjsipbot commented Aug 4, 2009

2009-08-04 11:22:02: @bennylp created the issue on trac ticket 930

The pjsua_acc_config.contact_params setting was used to add user defined parameters to the Contact URI. Some applications may need to add user defined parameters to the Contact header, and this will be supported by this ticket.

For consistency with RFC 3261, this will modify the semantic of the existing pjsua_acc_config.contact_params field as follows:

  • pjsua_acc_config.contact_params is now used to specify additional Contact header parameters
  • a new field, pjsua_acc_config.contact_uri_params, will be added, and this will be used to specify additional Contact URI parameters (the previous semantic of pjsua_acc_config.contact_params)

2009-08-04 15:36:50: @nanangizz changed status from new to closed


2009-08-04 15:36:50: @nanangizz set resolution to fixed


2009-08-04 15:36:50: @nanangizz commented

In r2852:

  • Changed semantic of pjsua_acc_config.contact_params, it is now used for specifying Contact header parameters (it was used for specifying Contact URI parameters).
  • Added a new field pjsua_acc_config.contact_uri_params, for specifying Contact URI parameters.
  • Added fields pjsua_acc_config.contact_params and pjsua_acc_config.contact_uri_params into python pjsua.
  • Updated/added option in pjsua app to specify Contact header parameters and Contact URI parameters.

2009-08-05 19:42:44: @nanangizz commented

In r2855:

  • Updated semantic of contact param in functions pjsip_dlg_create_uac(), pjsip_dlg_create_uas(), pjsip_endpt_create_request() and also variable pjsua_acc.contact to be Contact header value (was Contact URI).
  • Updated docs related to above modifications.
  • Fixed pjsua_im_send() in generating contact header, it should use pjsua_acc.contact instead, if it is set.

2009-08-11 19:11:05: @nanangizz commented

In r2860:

  • Fixed compile error for C++ (missing explicit casting from void*).

2009-08-15 12:00:36: @bennylp commented

In r2883:

  • Fixed test failure in pjsip_test, due to Contact URI is now interpreted as Contact header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants